proper handling of help commands (fixes #2154) #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
reviewed
Nov 29, 2023
internal/ui/prompt.go
Outdated
| @@ -122,6 +122,14 @@ func (p *Prompt) SendStrokes(s string) { | |||
| } | |||
| } | |||
|
|
|||
| // SetInactive sets the prompt is inactive. | |||
There was a problem hiding this comment.
nit: Perhaps Deactivate might be a better name since we are not setting any value?
Also doc could say something like: ... sets the prompt as inactive?
There was a problem hiding this comment.
Indeed. Sorry my English is not that good.
There was a problem hiding this comment.
Tx Jayson! nw - I shall not cast that first stone...
derailed
added
enhancement
wjiec
force-pushed
the
bugfix/cmd-help
branch
from
1bae020
to
210941c
Compare
wjiec
force-pushed
the
bugfix/cmd-help
branch
from
210941c
to
c469b6a
Compare
wjiec
changed the title
Merged
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #2154.
Steps to reproduce the problem:
:or/to open prompt bar?ESCto close the help pageThere is an extra prompt bar on the page and it cannot be closed by ESC.
This PR fixes the above problem, and also fixes the problem of unable to open the help page with the
helporhcommands.Fixes #2154